Bug repro: Exports which shadow built-ins are incorrectly included in non-"complete" report variants#4761
Draft
Josmithr wants to merge 2 commits intomicrosoft:mainfrom
Draft
Conversation
Josmithr
commented
Jun 5, 2024
| prop: number; | ||
| } | ||
|
|
||
| export { performance_2 as performance } |
Contributor
Author
There was a problem hiding this comment.
Note that the declaration of performance_2 was omitted, but the de-aliased export is still included.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was not an issue prior to the
reportVariantsfeature, but there are now cases where exports that are aliased to avoid conflicts with built-ins result in export statements being included in reports of incorrect release variants.I updated one of the test scenarios to include an API export called "performance", which shadows a global. It is tagged as
@internal. Note that in the non-"complete" report variants, an export for the item still occurs, while the aliased declaration is (correctly) omitted.